-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup-node is abnormally slow on Windows (?) #975
Comments
Hello @charlespwd |
I can confirm it reproduces here too: https://github.com/react-native-webview/react-native-webview/actions/runs/8134361620/job/22227194192 |
Hi @charlespwd If there is no cache actions/setup-node@v4 on Windows takes ~16s .when we re-run the job it takes some time to build the cache so setup-node takes more then 2 min to run. when we run the job again this time it takes less than 2 min because the cache was already there. The Subsequent runs are faster because the dependencies are loaded from the cache instead of being downloaded and installed again. Here is the screenshots for reference. And also Please make sure that your project is upgraded to node 20 because we have a cache fix for node 20 upgrade as part of this PR |
👋 It's much better indeed, but I feel like caching should be faster than without a cache. And right now the runtimes are almost equivalent. Anecdotal, but it seems like the action gets caught up by the tar.exe process. I seem to reach 100% rather quickly, and then have to wait for the de-archiving process. Here's a test I have made with And here's a test with The experience is very different on a |
Hello @charlespwd , We have done more investigation with regards to cache and it is the expected behavior from cache and here are few reasons why windows takes more time than ubuntu:
|
Hello @charlespwd |
It feels weird to me that it should be OK that installing and unzipping a cache entry takes (roughly) same amount of time. What's the point of caching in this case 😅? The whole purpose of using this is to save time. Are we really happy with that outcome? |
Hi @charlespwd, Apologies for the late response. Upon further investigation, we concur that the current duration for both installation and cache reloading isn't ideal. The cache reloading process should indeed be optimized for enhanced speed. We appreciate your feedback and will contemplate this as a potential feature request for future improvements. |
No worries. I understand what it's like to juggle a lot of priorities. Thank you 🙏 |
Description:
actions/setup-node@v4 on Windows takes ~4min
actions/setup-node@v4 on Ubuntu takes ~5s
Action version:
4
Platform:
Runner type:
Tools version:
yarn
Repro steps:
A description with steps to reproduce the issue. If you have a public example or repo to share, please provide the link.
https://github.com/Shopify/theme-tools/actions/runs/8066227793/job/22033787811
Expected behavior:
Windows cache-get doesn't take north of 2minutes when Ubuntu completes in 10s
Actual behavior:
Windows setup-node is significantly slower on Windows than Ubuntu
The text was updated successfully, but these errors were encountered: