-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to save the cache should not fail the entire run #592
Comments
Hello @thetorpedodog! Thank you for reporting this! |
For comparison, a failure to upload with the
It seems like the Python setup action needs to just ignore the failure to cache (and probably report it) the same way that the github/cache action does. Thank you for the quick response. |
Thanks for the clarification, I'm sure it will help. |
Hello @thetorpedodog. We released a new version of the action with changes to prevent the step from falling if there are issues with the cache services. For now I'm going to close the issue. |
Description:
When running a workflow, there may be an issue which causes the cache not to be saved. This should not cause the entire run to be reported as a failure.
Action version:
v4.5.0
Platform:
Runner type:
Tools version:
Independent of Python version.
Repro steps:
setup-python
step in a workflow with caching enabled.Example failed run: https://github.com/single-cell-data/TileDB-SOMA/actions/runs/3960808578/attempts/1
Expected behavior:
If the run finishes successfully, but the cache cannot be uploaded to the cache server, the failure to create the cache entry should be ignored.
Actual behavior:
When the cache fails to upload, the run is failed despite completing successfully in all other respects.
The text was updated successfully, but these errors were encountered: