Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow daysBeforeStale options to be float #833

Closed
sorodrigo opened this issue Sep 26, 2022 · 0 comments · Fixed by #841
Closed

Allow daysBeforeStale options to be float #833

sorodrigo opened this issue Sep 26, 2022 · 0 comments · Fixed by #841
Labels
enhancement New feature or request

Comments

@sorodrigo
Copy link

The problem

Currently we parse the daysBeforeStale as integer here. It would be great if we could add non integer values to allow higher resolution comparisons: 0.5days, 1.5days etc.

The solution

The solution would be as simple as changing parseInt to parseFloat. And adjust the messaging in other parts of the code.
@sorodrigo sorodrigo added the enhancement New feature or request label Sep 26, 2022
@irega irega mentioned this issue Oct 7, 2022
Merged
2 tasks
@irega irega mentioned this issue Oct 21, 2022
Closed
1 task
@irega irega mentioned this issue Dec 13, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow daysBeforeStale options to be float
1 participant
@sorodrigo