-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stale
label not removed from issue that had an update
#509
Comments
I can try out main and let you know - is main backward compatible with v3? |
@dfawley there are breaking changes, but you can refer to the documentation on the main branch (default). |
I'm also seeing the same: https://github.com/LekoArts/stale-bot-test/issues/23 I'll try the |
mhh, still doesn‘t work :/ |
@LekoArts @dfawley I think I know why this is happening. Right now, comments that were made by the I think one possible (albeit slightly hacky) solution might be to filter out comments based on the |
Interesting. Could "commenters to ignore" be configured manually instead of automagically determined based on who committed the configuration? |
Ahh, how ironic... Filtering based on the comment seems to make sense to me. I know that from my perspective, manually commenting a message identical to the stale message would make sense to be ignored. Idk how often someone would manually comment "marking this issue as stale" and not want it to be treated as being marked as stale. I agree, though, does feel a bit hacky, but I'm not the maintainer here so whatever you think is best seems fine. As an aside, we (Homebrew) eventually switched away from using @BrewTestBot as our stale actor in favor of the default GitHub actions bot (with the default Just a heads up: I'm on vacation this week so I won't be super quick to respond or be able to test things out. I'll should be fully back next Tuesday. |
Oh, here's another idea: you could use a markdown comment at the beginning so the comment markdown is this: <!-- #stale-message -->
This issue has been marked as stale... (whatever the stale-issue-message is) Since it's a comment, it won't be shown. Then, just ignore any comments that start with that commented-out placeholder. We do something similar for debugging in some of our automated comments for approval periods to some of our PRs. For example, this comment: Homebrew/brew#11555 (comment) actually contains this markdown (copy and pasted directly from the box that appears when I hit the edit button). <!-- #review-period-begin -->
Review period will end on 2021-06-18 at 18:14:26 UTC. We then query the issue comments and filter based on a regex later to find a match for the commented-out text. This wouldn't be much more work than just checking against the Again, I'm on vacation this week but let me know if I can help when I return. |
Describe your issue
stale
label not removed from issue that had an update.Your stale action configuration
https://github.com/grpc/grpc-go/blob/master/.github/workflows/stale.yml
Further context
Issue: grpc/grpc-go#4522
Run: https://github.com/grpc/grpc-go/runs/2841504434?check_suite_focus=true#step:2:94
Entries of note from the log above:
Note that it sees my update at 15:04:02, after the marked stale time of 04:52:42. But it says "Comments not made by actor or another bot: 0". What does "actor" mean in this instance?
The text was updated successfully, but these errors were encountered: