Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weak hashing functions MD5 #1304

Open
nishantsikarwar opened this issue Jan 7, 2023 · 2 comments
Open

weak hashing functions MD5 #1304

nishantsikarwar opened this issue Jan 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@nishantsikarwar
Copy link

Describe the enhancement

MD5 is a weak hash function and should not be used for security purposes. It is also not supported by the hash function in Azure Logic Apps. It would be nice to have a SHA256 hash function available.

Code Snippet
use sha256 instead of md5

const md5 = crypto.createHash('md5')

Additional information
None

@nishantsikarwar nishantsikarwar added the enhancement New feature or request label Jan 7, 2023
@robherley
Copy link
Contributor

👋 @nishantsikarwar the MD5 hash in this case is used for an integrity check (along with the CRC64) to protect against data corruption over the wire. it's not being used as a cryptographic hash function, so its insecure hashing properties can't be exploited in any way in this codepath

we do wish to remove this and only use CRC64, but for historical reasons it is still required at this time

@nishantsikarwar
Copy link
Author

Hi @robherley

thanks for the response.
any idea when do you plan to remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants