Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Parentheses in asset_name get replaced with periods #57

Open
archon810 opened this issue Aug 9, 2020 · 1 comment
Open

Parentheses in asset_name get replaced with periods #57

archon810 opened this issue Aug 9, 2020 · 1 comment

Comments

@archon810
Copy link

archon810 commented Aug 9, 2020

Hi,

We have the following action:

# Upload Development APK to Release
      - name: Upload Development APK to Release
        uses: actions/upload-release-asset@v1
        if: startsWith(github.ref, 'refs/tags/')
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          upload_url: ${{ steps.create_release.outputs.upload_url }}
          asset_path: "app/apks/${{ steps.generate_apk_names.outputs.NAME_DEVELOPMENT }}"
          asset_name: ${{ steps.generate_apk_names.outputs.NAME_DEVELOPMENT }}
          asset_content_type: application/zip

Our NAME_DEVELOPMENT contains parentheses (for example, app.prod-v1.3.0-(15-5)-6064eac-release.apk), but upon upload, the files end up with ( and ) replaced with periods, like so: app.prod-v1.3.0-.15-5.-6064eac-release.apk.

NAME_DEVELOPMENT is used by another action (actions/upload-artifact) and the same name gets uploaded properly there, with parentheses not replaced.

Is this a bug in this action?

Thanks.

@tscizzlebg
Copy link

I am seeing a similar thing with spaces being converted to periods. I can work around it by just not having spaces, but figured I'd note it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants