Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

当数据源没有绑定审核规则模版的时候，在界面上显示报错 #1945

Closed
Marcus9530 opened this issue Oct 25, 2023 · 2 comments
Closed

当数据源没有绑定审核规则模版的时候，在界面上显示报错 #1945

Marcus9530 opened this issue Oct 25, 2023 · 2 comments
Assignees
@rocky114
Labels
bug Something isn't working ui this issue is is related to the FE verified the issue all pr is verified
Milestone
v3.2311.0

Comments

@Marcus9530
Copy link
Collaborator

添加数据源的时候不设置审核规则模版，然后在界面上就可以看到报错
c51e5e6b-322d-42de-b4ab-9b67029cd402
@Marcus9530 Marcus9530 added the bug Something isn't working label Oct 25, 2023
@Marcus9530 Marcus9530 added this to the v3.2311.0 milestone Oct 25, 2023
@rocky114 rocky114 self-assigned this Oct 25, 2023
@Gygkimo95
Copy link
Collaborator

方案预期

新建数据源页面，新增开关“是否开启SQL审核业务 ”

  • 默认开启，此时，用户必填“审核规则模板”
  • 支持关闭，关闭时进行弹窗提示，关闭后不再填写“审核规则模板”

原型参考
默认状态
image

关闭时弹窗提示
image

关闭后
image

@rocky114 rocky114 mentioned this issue Oct 26, 2023
Merged
@LordofAvernus LordofAvernus added the ui this issue is is related to the FE label Oct 26, 2023
@siriuswh0327 siriuswh0327 mentioned this issue Oct 26, 2023
Merged
@siriuswh0327 siriuswh0327 mentioned this issue Nov 2, 2023
Merged
@rocky114 rocky114 closed this as completed Nov 8, 2023
@quexiuping
Copy link
Member

UI: main-ee 42bdca9f
DMS: main-ee 7f35dd7217
PROVISION: main 4135bf43ed
SQLE: main-ee 1ff8d69cab

@quexiuping quexiuping added the verified the issue all pr is verified label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rocky114 rocky114

Labels
bug Something isn't working ui this issue is is related to the FE verified the issue all pr is verified
Projects
None yet
Milestone
v3.2311.0
Development

No branches or pull requests
5 participants
@rocky114 @LordofAvernus @quexiuping @Marcus9530 @Gygkimo95