Update required Ruby version to 3.2.0 #5341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
commented
Nov 20, 2024
| @@ -1,3 +1,3 @@ | |||
| eval_gemfile '../Gemfile' | |||
|
|
|||
| gem 'activesupport', '~>7.2.1' | |||
| gem 'activesupport', github: 'rails/rails' | |||
There was a problem hiding this comment.
Moving it back to what it used to be
almalee24
force-pushed
the
update_to_ruby_3.2
branch
from
997a536
to
a64ee91
Compare
almalee24
commented
Nov 20, 2024
| @@ -117,7 +117,7 @@ def test_parse_invalid_json | |||
|
|
|||
| assert_equal({ 'errors' => '{"key1": "value1", "key2": "value2"', | |||
| 'status' => 'Unable to parse JSON response', | |||
| 'message' => "859: unexpected token at '{\"key1\": \"value1\", \"key2\": \"value2\"'" }, | |||
| 'message' => "unexpected token at '{\"key1\": \"value1\", \"key2\": \"value2\"'" }, | |||
There was a problem hiding this comment.
This test is failing in master
almalee24
force-pushed
the
update_to_ruby_3.2
branch
from
a64ee91
to
6eadf75
Compare
sinourain
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM! I ran the tests and they work, here is a summary:
Finished in 27.42962 seconds.
6112 tests, 80798 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
222.82 tests/s, 2945.65 assertions/s
Running RuboCop...
Inspecting 803 files
803 files inspected, no offenses detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.