Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicAuth doesn't have constructor from Basic #326

Closed
skylark-17 opened this issue Sep 13, 2023 · 0 comments · Fixed by #327
Closed

BasicAuth doesn't have constructor from Basic #326

skylark-17 opened this issue Sep 13, 2023 · 0 comments · Fixed by #327
Labels
A-httpauth Project: actix-web-httpauth C-improvement Category: an improvement to existing functionality good first issue Good for newcomers

Comments

@skylark-17
Copy link

I have BasicAuth as one of arguments in my view function, it parses BasicAuth. I also want to test its work. But I can only construct class Basic which is inner private field in BasicAuth. I would be appreciate if BasicAuth would implement From<Basic> trait
@robjtede robjtede added C-improvement Category: an improvement to existing functionality A-httpauth Project: actix-web-httpauth good first issue Good for newcomers labels Sep 13, 2023
@52 52 mentioned this issue Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-httpauth Project: actix-web-httpauth C-improvement Category: an improvement to existing functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement From<Basic> for BasicAuth 52/actix-extras
2 participants
@robjtede @skylark-17