Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(session): add deadpool-redis compatibility #381

Merged
merged 39 commits into from
Aug 6, 2024

Conversation

0rangeFox
Copy link
Contributor

@0rangeFox 0rangeFox commented Jan 8, 2024

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

A new feature named redis-dp-session has been added, as well as the logic for accepting the deadpool-redis library in the redis-rs file, since deadpool-redis uses redis-rs in under the hood, so both are compatible and instead of duplicating, some attributes have been added to control the compilation of the features that are selected.

@robjtede robjtede added A-session Project: actix-session B-semver-minor labels Jan 19, 2024
@0rangeFox
Copy link
Contributor Author

The doc tests workflow is failing because there is an example code in redis_rs in the Deadpool Redis section, but ins't marked only for the feature redis-dp-session, is there any way to control this so that the workflow succeeds?

@0rangeFox 0rangeFox force-pushed the session-deadpool_redis-compatibility branch from af23196 to 30b7402 Compare January 23, 2024 01:16
@robjtede
Copy link
Member

robjtede commented Aug 3, 2024

This is actually blocked on a new release of deadpool-redis with a redis v0.26 dependency update.

actix-session/Cargo.toml Outdated Show resolved Hide resolved
@robjtede
Copy link
Member

robjtede commented Aug 6, 2024

thanks for your work on this @0rangeFox 🎉

@robjtede robjtede added this pull request to the merge queue Aug 6, 2024
Merged via the queue into actix:master with commit 504e894 Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-session Project: actix-session B-semver-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants