-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParticleID collision in Geant4 #2041
Comments
what I got from the code is that from the code and discussions I understand the barcode in the following way
this is even more complicated than I thought. the secondary vertex part should only be used for the secondaries and not tertiaries |
Maybe I am missing something but in the G4 case shouldn't the |
Hmm I don't think so. It should be just different within one generation of one of the input particles, right? |
Ah yes you are right I think I see it now ! |
Resolved by #2039 |
We have noticed that the particles' barcode of the Geant 4 simulation can (and does) overlap during simulation. This means that many for a given track ID, we can have the hits corresponding to many simulated tracks associated. For now, we believe that if the standard particle selection is applied, this effect should be negligible (as it mainly affects the secondary), but this should be tested.
@benjaminhuth and @andiwand are looking into modifying the barcode information stored in the G4 simulation to avoid such overlap. For now, those barcodes are directly inherited from the Fatras simulation and might not be appropriate when used in G4.
@benjaminhuth has also opened a PR related to this issue: #2039.
The text was updated successfully, but these errors were encountered: