Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleID collision in Geant4 #2041

Closed
Corentin-Allaire opened this issue Apr 19, 2023 · 5 comments
Closed

ParticleID collision in Geant4 #2041

Corentin-Allaire opened this issue Apr 19, 2023 · 5 comments
Assignees

Comments

@Corentin-Allaire
Copy link
Contributor

We have noticed that the particles' barcode of the Geant 4 simulation can (and does) overlap during simulation. This means that many for a given track ID, we can have the hits corresponding to many simulated tracks associated. For now, we believe that if the standard particle selection is applied, this effect should be negligible (as it mainly affects the secondary), but this should be tested.

@benjaminhuth and @andiwand are looking into modifying the barcode information stored in the G4 simulation to avoid such overlap. For now, those barcodes are directly inherited from the Fatras simulation and might not be appropriate when used in G4.

@benjaminhuth has also opened a PR related to this issue: #2039.

@andiwand
Copy link
Contributor

andiwand commented Apr 19, 2023

what I got from the code is that EventGeneration will only use the primary vertex ID, Pythia will set the secondary vertex ID correctly but the particle ID is wasting space and Geant4 will only use the particle generation

from the code and discussions I understand the barcode in the following way

  • primary vertex is simply the primary vertex ID, no ambiguity here
  • secondary vertex is the secondary vertex ID. this could come from event gen but also from simulation. we have to be careful if both of them touch this information
  • particle is the particle ID within that primary and secondary vertex
  • generation is used for everything after primary and secondary
  • sub particle identifies the particle within each generation

this is even more complicated than I thought. the secondary vertex part should only be used for the secondaries and not tertiaries

@Corentin-Allaire
Copy link
Contributor Author

Maybe I am missing something but in the G4 case shouldn't the sub particle value be different for all particles then ?

@benjaminhuth
Copy link
Member

benjaminhuth commented Apr 19, 2023

Hmm I don't think so. It should be just different within one generation of one of the input particles, right?

@Corentin-Allaire
Copy link
Contributor Author

Ah yes you are right I think I see it now !

@Corentin-Allaire
Copy link
Contributor Author

Resolved by #2039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants