Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Payees should sort favorite payees before other suggested payees. #3331

Closed
2 tasks done
qedi-r opened this issue Aug 30, 2024 · 3 comments · Fixed by #3412
Closed
2 tasks done

[Bug]: Payees should sort favorite payees before other suggested payees. #3331

qedi-r opened this issue Aug 30, 2024 · 3 comments · Fixed by #3412
Labels
bug Something isn't working

Comments

@qedi-r
Copy link
Contributor

qedi-r commented Aug 30, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Right now, payees are sorted in three groups, suggested payees, payees and transfers. All are sorted alphabetically. Suggested payees draws from two different sources though, users can either mark payees as favorites, or the most frequently used payees in the past 12 weeks, if users haven't marked at least five payees as favorites.

Since users have specifically marked favorites as desired payees, they should be shown in the suggested payees first. Then common payees should be added. Both subsections should remain otherwise unmarked and be sorted alphabetically.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

No response

Operating System

Windows 11

@qedi-r qedi-r added the bug Something isn't working label Aug 30, 2024
@youngcw
Copy link
Member

youngcw commented Sep 9, 2024

Didn't this get fixed?

@qedi-r
Copy link
Contributor Author

qedi-r commented Sep 9, 2024

No, I spent too much time figuring out the component test framework. I've created a PR for it now.

@youngcw
Copy link
Member

youngcw commented Sep 9, 2024

If there is an open PR then you should like it to this issue by adding "fixed #" to the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants