From 4c3306d258d14882e8cef2b6a4702fcec455d81a Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Tue, 17 Sep 2024 22:30:54 +0100
Subject: [PATCH] :bug: (synced-prefs) fix bulk-reading not working in import
 modal

---
 packages/desktop-client/src/hooks/useSyncedPrefs.ts | 2 +-
 packages/loot-core/src/client/query-hooks.tsx       | 2 +-
 upcoming-release-notes/3460.md                      | 6 ++++++
 3 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 upcoming-release-notes/3460.md

diff --git a/packages/desktop-client/src/hooks/useSyncedPrefs.ts b/packages/desktop-client/src/hooks/useSyncedPrefs.ts
index 6047852022..ca8788ecb3 100644
--- a/packages/desktop-client/src/hooks/useSyncedPrefs.ts
+++ b/packages/desktop-client/src/hooks/useSyncedPrefs.ts
@@ -16,7 +16,7 @@ export function useSyncedPrefs(): [SyncedPrefs, SetSyncedPrefsAction] {
 
   const prefs = useMemo<SyncedPrefs>(
     () =>
-      queryData.reduce(
+      (queryData ?? []).reduce(
         (carry, { id, value }) => ({
           ...carry,
           [id]: value,
diff --git a/packages/loot-core/src/client/query-hooks.tsx b/packages/loot-core/src/client/query-hooks.tsx
index 930acfc587..8e4f5810aa 100644
--- a/packages/loot-core/src/client/query-hooks.tsx
+++ b/packages/loot-core/src/client/query-hooks.tsx
@@ -82,7 +82,7 @@ export function useQuery<Response = unknown>(
   makeQuery: () => Query,
   deps: DependencyList,
 ): {
-  data: Response;
+  data: null | Response;
   overrideData: (newData: Response) => void;
   isLoading: boolean;
 } {
diff --git a/upcoming-release-notes/3460.md b/upcoming-release-notes/3460.md
new file mode 100644
index 0000000000..b39dfcb9c9
--- /dev/null
+++ b/upcoming-release-notes/3460.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatisJanis]
+---
+
+SyncedPrefs: fix import prefs not reading correctly.