From d394b8d527284ae7654bb2321cb4697f3ef8bd3d Mon Sep 17 00:00:00 2001 From: Sonu Kumar Singh Date: Tue, 19 Jul 2022 23:07:20 +0530 Subject: [PATCH] Adapt changes for logger changed to construct --- pkg/logger/logger.go | 2 +- pkg/testrunner/result/summary-poster_test.go | 5 +++-- pkg/util/slack-table-post_test.go | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/logger/logger.go b/pkg/logger/logger.go index ea48ad0e2e..8a438e494c 100644 --- a/pkg/logger/logger.go +++ b/pkg/logger/logger.go @@ -98,7 +98,7 @@ func New(config *Config) (logr.Logger, error) { zapLog, err := zapCfg.Build(zap.AddCallerSkip(1)) if err != nil { - return nil, err + return logr.Logger{}, err } return zapr.NewLogger(zapLog), nil } diff --git a/pkg/testrunner/result/summary-poster_test.go b/pkg/testrunner/result/summary-poster_test.go index 7a19154b81..956aafeb5d 100644 --- a/pkg/testrunner/result/summary-poster_test.go +++ b/pkg/testrunner/result/summary-poster_test.go @@ -15,6 +15,7 @@ package result import ( + "github.com/go-logr/logr" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" @@ -44,7 +45,7 @@ var _ = Describe("summary-poster", func() { runs = append(runs, run) items := parseTestrunsToTableItems(runs) Expect(items).To(HaveLen(1)) - slack, err := util.RenderTableForSlack(nil, items) + slack, err := util.RenderTableForSlack(logr.Logger{}, items) Expect(err).ToNot(HaveOccurred()) Expect(slack).To(ContainSubstring(string(util.StatusSymbolSuccess))) Expect(slack).ToNot(ContainSubstring(string(util.StatusSymbolNA))) @@ -82,7 +83,7 @@ var _ = Describe("summary-poster", func() { runs = append(runs, run) items := parseTestrunsToTableItems(runs) Expect(items).To(HaveLen(2)) - slack, err := util.RenderTableForSlack(nil, items) + slack, err := util.RenderTableForSlack(logr.Logger{}, items) Expect(err).ToNot(HaveOccurred()) Expect(slack).To(ContainSubstring(string(util.StatusSymbolSuccess) + util.SymbolOffset + string(util.StatusSymbolFailure))) Expect(slack).ToNot(ContainSubstring(string(util.StatusSymbolNA))) diff --git a/pkg/util/slack-table-post_test.go b/pkg/util/slack-table-post_test.go index 77f6394807..2a29e4b194 100644 --- a/pkg/util/slack-table-post_test.go +++ b/pkg/util/slack-table-post_test.go @@ -15,6 +15,7 @@ package util_test import ( + "github.com/go-logr/logr" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" @@ -55,7 +56,7 @@ var _ = Describe("Slack Table Post", func() { StatusSymbol: util.StatusSymbolSuccess, } tis := []*util.TableItem{&ti} - table, err := util.RenderTableForSlack(nil, tis) + table, err := util.RenderTableForSlack(logr.Logger{}, tis) Expect(err).ToNot(HaveOccurred()) Expect(table).To(ContainSubstring("(orange)")) Expect(table).To(ContainSubstring("[para]"))