Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-ray] bazel error due to platforms #240

Closed
acxz opened this issue May 16, 2023 · 5 comments
Closed

[python-ray] bazel error due to platforms #240

acxz opened this issue May 16, 2023 · 5 comments

Comments

@acxz
Copy link
Owner

acxz commented May 16, 2023

ERROR: /home/acxz/.cache/bazel/_bazel_acxz/f919352e0a1de94b52d2f0b261a1b88c/external/bazel_tools/platforms/BUILD:89:6: in alias rule @bazel_tools//platforms:windows: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or preferably declare dependency on https://github.com/bazelbuild/platforms. See https://github.com/bazelbuild/bazel/issues/8622 for details.
ERROR: /home/acxz/.cache/bazel/_bazel_acxz/f919352e0a1de94b52d2f0b261a1b88c/external/bazel_tools/platforms/BUILD:89:6: Analysis of target '@bazel_tools//platforms:windows' failed
ERROR: /home/acxz/.cache/bazel/_bazel_acxz/f919352e0a1de94b52d2f0b261a1b88c/external/com_google_protobuf/BUILD:513:10: While resolving toolchains for target @com_google_protobuf//:protoc: invalid registered toolchain '@bazel_skylib//toolchains/unittest:cmd_toolchain': 
ERROR: Analysis of target '//:ray_pkg' failed; build aborted: 
@petronny
Copy link

Hi, this issue can be solved by building with bazel5.

https://github.com/arch4edu/cactus/actions/runs/5133068703/jobs/9236993635

But new error shows:

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from bazel-out/k8-opt/bin/external/com_github_spdlog/_virtual_includes/spdlog/spdlog/fmt/fmt.h:20,
                 from bazel-out/k8-opt/bin/external/com_github_spdlog/_virtual_includes/spdlog/spdlog/common.h:36,
                 from bazel-out/k8-opt/bin/external/com_github_spdlog/_virtual_includes/spdlog/spdlog/details/file_helper.h:6,
                 from bazel-out/k8-opt/bin/external/com_github_spdlog/_virtual_includes/spdlog/spdlog/sinks/basic_file_sink.h:6,
                 from bazel-out/k8-opt/bin/_virtual_includes/ray_util/ray/util/event.h:32,
                 from bazel-out/k8-opt/bin/_virtual_includes/ray_common/ray/common/file_system_monitor.h:27,
                 from bazel-out/k8-opt/bin/_virtual_includes/plasma_store_server_lib/ray/object_manager/plasma/store_runner.h:8,
                 from src/ray/object_manager/plasma/store_runner.cc:1:
bazel-out/k8-opt/bin/external/com_github_spdlog/_virtual_includes/spdlog/spdlog/fmt/bundled/core.h:443:7: error: identifier 'char8_t' is a keyword in C++20 [-Werror=c++20-compat]
  443 | using char8_t FMT_DEPRECATED_ALIAS = internal::char8_type;
      |       ^~~~~~~
cc1plus: all warnings being treated as errors
INFO: Elapsed time: 542.853s, Critical Path: 63.84s
INFO: 1840 processes: 1120 internal, 720 processwrapper-sandbox.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully

I think it can be solved by adjusting the build flag or building with gcc12 or gcc11.

@petronny
Copy link

ray-project/ray#35200

@petronny
Copy link

Building with gcc12 solve the issue. Also added git and libxcrypt-compat to makedepends.

@acxz
Copy link
Owner Author

acxz commented Jul 21, 2024

Closing this issue as @carlosal1015 is now maintaining this package. Thanks for all the bug reporting and tracking @petronny. When I get back to RL stuff again, I'll be sure to keep this in mind.

@carlosal1015 please address these comments when you get the chance.

@acxz acxz closed this as completed Jul 21, 2024
@carlosal1015
Copy link
Contributor

Thanks, I will take a look today about conflict mesa demos and and look the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants