Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprites looking distorted on Pop_OS! 22.04 #6

Closed
Ysujy opened this issue Aug 19, 2022 · 4 comments
Closed

Sprites looking distorted on Pop_OS! 22.04 #6

Ysujy opened this issue Aug 19, 2022 · 4 comments

Comments

@Ysujy
Copy link

Ysujy commented Aug 19, 2022

OS:
Pop_OS! 22.04

Dependencies:
bash/jammy,now 5.1-6ubuntu1 amd64
curl/jammy-security,jammy-updates,now 7.81.0-1ubuntu1.3 amd64
jq/jammy,now 1.6-2.1ubuntu3 amd64
imagemagick/jammy,now 8:6.9.11.60+dfsg-1.3build2 amd64
chafa/jammy,now 1.8.0-1 amd64

Fonts used
Powerline
Noto Mono

Terminals used
Gnome Terminal
Alacritty

Shell
zsh
bash

Output of $ pokeshell random

image

Output of $ pokeshell random -a

pokeshell

The distortion might be harder to make out with animated sprites, but they're still present.


Thank you for creating such a cool project. I hope we can get to the bottom of this issue.

@Ysujy Ysujy changed the title Sprites look distorted on Pop_OS! 22.04 Sprites looking distorted on Pop_OS! 22.04 Aug 19, 2022
@acxz
Copy link
Owner

acxz commented Aug 19, 2022

Thanks for making an issue!

So I actually think they don't look distorted. Can you clarify what kind of output you would like? Are you looking for true image support like sixels/iTerm2/kitty protocols?

@Ysujy
Copy link
Author

Ysujy commented Aug 19, 2022

You're right!!! I didn't know that neither Gnome Terminal nor Alacritty have true image support. Just tried Kitty and the output is looking way better.

Unfortunately, animated sprites are still looking kinda distorted

Screenshot from 2022-08-20 00-40-25

As compared to the image in the README

Screenshot from 2022-08-20 00-43-29

@acxz
Copy link
Owner

acxz commented Aug 19, 2022

Nice glad to hear you got it working!

For the animations that you see on the readme, an older version of pokeshell was used that utilized timg. I recently made the switch over to chafa since it overall has more support. However, one open issue it has is that it doesn't play nice with gifs for the kitty terminal.

See the following issue: hpjansson/chafa#104

We can do two things, wait for chafa to fix their kitty support, or add timg support back in. The time it takes to add timg support, chafa will probably have the issue resolved, so we should probably just wait on it.

@Ysujy
Copy link
Author

Ysujy commented Aug 19, 2022

Glad to hear that there might be a fix under way. Anyway, thank you for helping out and have a good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants