From 0170547f005dc8c9442632e8dad3d909ead97b6c Mon Sep 17 00:00:00 2001 From: Daniel Lemire Date: Tue, 19 Mar 2024 10:58:16 -0400 Subject: [PATCH] adding test for undici issue 971 (#611) * adding test for https://github.com/nodejs/undici/pull/2971 * lint --- tests/basic_tests.cpp | 14 ++++++++++++++ tools/run-clangcldocker.sh | 25 ++++++++----------------- 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/tests/basic_tests.cpp b/tests/basic_tests.cpp index 4435ff9ab..79ccbc667 100644 --- a/tests/basic_tests.cpp +++ b/tests/basic_tests.cpp @@ -417,3 +417,17 @@ TYPED_TEST(basic_tests, nodejs_51619) { ASSERT_FALSE(out); SUCCEED(); } + +// https://github.com/nodejs/undici/pull/2971 +TYPED_TEST(basic_tests, nodejs_undici_2971) { + std::string_view base = + "https://non-ascii-location-header.sys.workers.dev/redirect"; + auto base_url = ada::parse(base); + ASSERT_TRUE(base_url); + auto out = ada::parse("/\xec\x95\x88\xeb\x85\x95", &*base_url); + ASSERT_TRUE(out); + ASSERT_EQ( + out->get_href(), + R"(https://non-ascii-location-header.sys.workers.dev/%EC%95%88%EB%85%95)"); + SUCCEED(); +} \ No newline at end of file diff --git a/tools/run-clangcldocker.sh b/tools/run-clangcldocker.sh index deeb8ef63..b7ad42237 100755 --- a/tools/run-clangcldocker.sh +++ b/tools/run-clangcldocker.sh @@ -1,31 +1,22 @@ #!/usr/bin/env bash set -e -SCRIPT_PATH="$( cd "$(dirname "$0")" ; pwd -P )" -ROOT_PATH=$SCRIPT_PATH/.. -ALL_ADA_FILES=$(cd "$ROOT_PATH" && git ls-tree --full-tree --name-only -r HEAD | grep -e ".*\.\(c\|h\|cc\|cpp\|hh\)\$" | grep -vFf clang-format-ignore.txt) +COMMAND=$* +SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )" +MAINSOURCE=$SCRIPTPATH/.. +ALL_ADA_FILES=$(cd $MAINSOURCE && git ls-tree --full-tree --name-only -r HEAD | grep -e ".*\.\(c\|h\|cc\|cpp\|hh\)\$" | grep -vFf clang-format-ignore.txt) if clang-format-15 --version 2>/dev/null | grep -qF 'version 15.'; then - cd "$ROOT_PATH"; clang-format-15 --style=file --verbose -i "$@" "$ALL_ADA_FILES" + cd $MAINSOURCE; clang-format-15 --style=file --verbose -i "$@" $ALL_ADA_FILES exit 0 elif clang-format --version 2>/dev/null | grep -qF 'version 15.'; then - cd "$ROOT_PATH"; clang-format --style=file --verbose -i "$@" "$ALL_ADA_FILES" + cd $MAINSOURCE; clang-format --style=file --verbose -i "$@" $ALL_ADA_FILES exit 0 fi echo "Trying to use docker" command -v docker >/dev/null 2>&1 || { echo >&2 "Please install docker. E.g., go to https://www.docker.com/products/docker-desktop Type 'docker' to diagnose the problem."; exit 1; } docker info >/dev/null 2>&1 || { echo >&2 "Docker server is not running? type 'docker info'."; exit 1; } -if [ -t 0 ]; - then DOCKER_ARGS=-it; -fi - +if [ -t 0 ]; then DOCKER_ARGS=-it; fi docker pull kszonek/clang-format-15 -docker run --rm $DOCKER_ARGS \ - -v "$ROOT_PATH":"$ROOT_PATH":Z \ - -w "$ROOT_PATH" \ - -u "$(id -u "$USER"):$(id -g "$USER")" \ - kszonek/clang-format-15 \ - --style=file \ - --verbose \ - -i "$@" "$ALL_ADA_FILES" +docker run --rm $DOCKER_ARGS -v "$MAINSOURCE":"$MAINSOURCE":Z -w "$MAINSOURCE" -u "$(id -u $USER):$(id -g $USER)" kszonek/clang-format-15 --style=file --verbose -i "$@" $ALL_ADA_FILES