From e24821a28bb83f0ab5faa6f851b0b9b8f348db4e Mon Sep 17 00:00:00 2001
From: Yagiz Nizipli <yagiz@cloudflare.com>
Date: Fri, 24 Jan 2025 16:01:25 -0500
Subject: [PATCH] update url_pattern to pass more wpt on node.js

---
 include/ada/implementation.h  | 2 --
 include/ada/url_pattern-inl.h | 5 -----
 2 files changed, 7 deletions(-)

diff --git a/include/ada/implementation.h b/include/ada/implementation.h
index 33e166715..e79670031 100644
--- a/include/ada/implementation.h
+++ b/include/ada/implementation.h
@@ -53,8 +53,6 @@ bool can_parse(std::string_view input,
  * @param input valid UTF-8 string or URLPatternInit struct
  * @param base_url an optional valid UTF-8 string
  * @param options an optional url_pattern_options struct
- * @param provider an optional regex provider. if not provided, it will
- * use ada::url_pattern_regex::std_regex_provider
  * @return url_pattern instance
  */
 template <url_pattern_regex::regex_concept regex_provider =
diff --git a/include/ada/url_pattern-inl.h b/include/ada/url_pattern-inl.h
index 2a371f63a..d824521db 100644
--- a/include/ada/url_pattern-inl.h
+++ b/include/ada/url_pattern-inl.h
@@ -46,11 +46,6 @@ url_pattern_component<regex_provider>::create_component_match_result(
   auto result =
       url_pattern_component_result{.input = std::string(input), .groups = {}};
 
-  // If input is empty, then groups will always be empty.
-  if (input.empty() || exec_result.empty()) {
-    return result;
-  }
-
   // Optimization: Let's reserve the size.
   result.groups.reserve(exec_result.size() - 1);