Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting error #23

Closed
Eths33 opened this issue Nov 18, 2021 · 4 comments
Closed

Commenting error #23

Eths33 opened this issue Nov 18, 2021 · 4 comments

Comments

@Eths33
Copy link

Eths33 commented Nov 18, 2021

In the file Adafruit_SGP30.h on lines 58 - 68 the same comment was used 3 times referencing CO2. As a result H2 and Ethanol do not have a comment.
@caternuson
Copy link
Contributor

Yep, looks like a copy paste error, and the resulting dox are also as expected:
image

Thanks for spotting that. Want to submit a PR to fix?

@Eths33
Copy link
Author

Eths33 commented Feb 10, 2022

I noticed this again when I returned to working on my project.
I submitted a pull request.

@caternuson
Copy link
Contributor

Looks like the pull request (#24) was closed? Is there a plan to reopen or resubmit it?

@caternuson caternuson mentioned this issue Feb 2, 2024
Merged
@caternuson
Copy link
Contributor

Closing. Fixed with #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caternuson @Eths33