Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop i2cPorts #145

Open
lorennorman opened this issue Apr 10, 2024 · 0 comments
Open

Drop i2cPorts #145

lorennorman opened this issue Apr 10, 2024 · 0 comments
Labels
api-v2 todo before protobuf api v2 ships

Comments

@lorennorman
Copy link
Contributor

We want to drop I2C settings from the JSON, because:

  • the SDA and SCL pins are always known in C and Python for every board's primary I2C port
  • we don't support more than 1 i2c port yet anyway
  • protobuf traffic will get smaller without the extra payload

Some backend code references this JSON property and so needs to be cleaned up:

  • mqtt broker uses it to build the v1 protobufs
    • THIS MEANS WE CAN'T DROP THE FIELDS UNTIL WE SUNSET V1
  • wipper frontend uses this property's present to decide if a device supports i2c
    • would need to be replaced with at least some kind of i2cSupport: true boolean
@lorennorman lorennorman added the api-v2 todo before protobuf api v2 ships label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-v2 todo before protobuf api v2 ships
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorennorman