Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite duration not calculated if suite contains pending or skipped tests #276

Closed
PeterRozum opened this issue Apr 17, 2019 · 3 comments · Fixed by #278
Closed

Test suite duration not calculated if suite contains pending or skipped tests #276

PeterRozum opened this issue Apr 17, 2019 · 3 comments · Fixed by #278

Comments

@PeterRozum
Copy link

Describe the bug
When a test suite (describe()) contains a test that is skipped or pending in a test run, the test suite duration is 0 even is it contains a tests that ran for some time.

Code Reproduce
Link to repo where the issue can reliably be reproduced: https://github.com/KitoW/mochawesomeSuitRunDuration

Expected behavior
I would expect a test suite duration to always display a sum of duration of all tests that were executed within the test suite.

Screenshots
report screenshot

Environment (please complete the following information):

  • Platform: Windows 10
  • mochawesome version: v3.1.1
  • mocha (or other test library) version: mocha v6.1.3
  • Node version: v8.12.0

Additional context
Reproduction contain scenario where test suite contains pending test (xit.() ). the same can be reproduced for skipped tests.

sample report files: testreport.zip

@adamgruber
Copy link
Owner

@kitow Thanks for the detailed issue! I'll try to carve out some time to look into this soon.

@adamgruber
Copy link
Owner

Should be fixed in v3.1.2

@PeterRozum
Copy link
Author

Thanks for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants