Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the unused code to write entries in Zip Headers #212

Merged
merged 2 commits into from
May 30, 2017

Conversation

kenkendk
Copy link
Contributor

This is more a suggestion than a request.

As I found out with #210 there is some unused code.

The unused code appears because the writing of zip files is done from the Writers.Zip namespace, and the reading is done in Common.Zip.Headers.

I guess there could be a consolidation of the two, such that the same classes represents the same entries for both readers and writers. If this is a better approach, much of the code in ZipWriter.cs can be moved into the Common.Zip.Headers classes, but there are edge cases, as the writers need to store some temporary information in the structures (can be solved by a writer-specific class deriving from the other entry perhaps).

@adamhathcock adamhathcock merged commit cce9754 into adamhathcock:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants