-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new event handler to allow tracking of progress of extraction progress for individual entry #226
Merged
Merged
Add new event handler to allow tracking of progress of extraction progress for individual entry #226
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
467fc2d
Add new feature to allow injection of an action into the extraction p…
b8ef1ec
Revert "Add new feature to allow injection of an action into the extr…
683d271
Add new event to be able to track progress of extraction of individua…
e05f984
Use strongly typed ReaderProgress instead of object[]
0990b06
Create new TransferTo method and pass Entry and IReaderExtractionList…
2aa123c
Remove begin and end events since this can now be tracked via progres…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,17 @@ | ||
using System; | ||
using SharpCompress.Readers; | ||
|
||
namespace SharpCompress.Common | ||
{ | ||
public class ReaderExtractionEventArgs<T> : EventArgs | ||
{ | ||
internal ReaderExtractionEventArgs(T entry) | ||
internal ReaderExtractionEventArgs(T entry, ReaderProgress readerProgress = null) | ||
{ | ||
Item = entry; | ||
ReaderProgress = readerProgress; | ||
} | ||
|
||
public T Item { get; private set; } | ||
public ReaderProgress ReaderProgress { get; private set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
| ||
|
||
using System; | ||
using SharpCompress.Common; | ||
|
||
namespace SharpCompress.Readers | ||
{ | ||
public class ReaderProgress | ||
{ | ||
private readonly IEntry _entry; | ||
public long BytesTransferred { get; private set; } | ||
public int Iterations { get; private set; } | ||
|
||
public int PercentageRead => (int)Math.Round(PercentageReadExact); | ||
public double PercentageReadExact => (float)BytesTransferred / _entry.Size * 100; | ||
|
||
public ReaderProgress(IEntry entry, long bytesTransferred, int iterations) | ||
{ | ||
_entry = entry; | ||
BytesTransferred = bytesTransferred; | ||
Iterations = iterations; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the way this was done