Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #302: PlayHistory should contain a Track object rather than a SimpleTrack, due to a change in the Spotify API #303

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

Nielssg
Copy link
Contributor

@Nielssg Nielssg commented Dec 23, 2021

Closes #302

…impleTrack, due to a change in the Spotify API

Closes #302
@Nielssg
Copy link
Contributor Author

Nielssg commented Dec 23, 2021

@adamint it seems like the tests are failing due to invalid credentials, are the credentials set to the correct ones or should I also add them to my fork (even though the actions run from this repo, not my fork)? Running the tests locally is no problem fortunately.

@Nielssg Nielssg marked this pull request as ready for review December 23, 2021 23:28
@adamint
Copy link
Owner

adamint commented Dec 28, 2021

@Nielssg this was due to a misconfiguration in the Action, sorry! No action required, I've confirmed this can be merged, thanks 😄

@adamint adamint closed this Dec 28, 2021
@adamint adamint reopened this Dec 28, 2021
@adamint adamint merged commit b9313ca into adamint:dev Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants