Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log messages #49

Closed
adamralph opened this issue Aug 5, 2018 · 0 comments · Fixed by #55
Closed

Better log messages #49

adamralph opened this issue Aug 5, 2018 · 0 comments · Fixed by #55
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@adamralph
Copy link
Owner

adamralph commented Aug 5, 2018

Before

Success

Failure

Problems

  • In both cases, the escaping of ", /, and : is flawed. It's easy to construct target names which make the resulting string ambiguous.
  • In the failure case, the last line is confusing, since hell"o actually succeeded.

After

Success

Failure

Solutions

  • The escaping has been removed. If people want to use weird target names that screw up the output, it's their prerogative.
  • In the failure case, the confusion is lessened, since the message format follows that of the "Starting..." message. 🤷‍♂️

And some extra colour to boot. 🌈

@adamralph adamralph added enhancement New feature or request in-progress labels Aug 5, 2018
@adamralph adamralph added this to the 1.1.0 milestone Aug 5, 2018
@adamralph adamralph self-assigned this Aug 5, 2018
@adamralph adamralph changed the title Better log messages for overall success and failure Better log messages Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant