Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static RunTargetsWithoutExiting overload with Options returns before running targets #611

Closed
adamralph opened this issue Jul 11, 2021 · 2 comments · Fixed by #610 or #612
Closed

Static RunTargetsWithoutExiting overload with Options returns before running targets #611

adamralph opened this issue Jul 11, 2021 · 2 comments · Fixed by #610 or #612
Labels
bug Something isn't working
Milestone
3.7.1

Comments

@adamralph
Copy link
Owner

Version(s)

3.7.0

To reproduce

Steps to reproduce the behaviour:

  1. Specify some targets
  2. Call the static RunTargetsWithoutExiting(RunTargetsWithoutExiting(IEnumerable<string>, Options) overload

Expected behaviour

The targets are run and then the method returns.

Actual behaviour

The method returns and then the targets are run (on a separate thread).

Workarounds

Use another RunTargets... overload.

Additional context

Thanks to @alibresco for discovering this bug and fixing it in #610.
@adamralph adamralph added the bug Something isn't working label Jul 11, 2021
@adamralph adamralph linked a pull request Jul 11, 2021 that will close this issue
Fix RunTargetsWithoutExiting static method async call #610
Merged
@adamralph adamralph added this to the 3.7.1 milestone Jul 11, 2021
@adamralph
Copy link
Owner Author

Re-opening until this is backported to 3.7.x.

@adamralph adamralph reopened this Jul 11, 2021
@adamralph adamralph mentioned this issue Jul 11, 2021
Merged
@adamralph adamralph linked a pull request Jul 11, 2021 that will close this issue
Fix RunTargetsWithoutExiting static method async call #612
Merged
@adamralph
Copy link
Owner Author

Closed in #612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.7.1
1 participant
@adamralph