Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabs from right to left #60

Open
elkizana opened this issue Apr 25, 2021 · 3 comments
Open

Add tabs from right to left #60

elkizana opened this issue Apr 25, 2021 · 3 comments

Comments

@elkizana
Copy link

What should I modify to add tabs from right to left ?

@adamschwartz
Copy link
Owner

In an ideal world, chrome-tabs should be rewritten to use CSS logical properties, e.g. padding-inline-start in place of padding-left. That way when used in conjunction with a wrapping element with direction: rtl, everything would “just work”. Here’s a small example of CSS logical properties in use.

Up until this project implements CSS logical properties, though, you could theoretically change every instance of left to right, and vice-versa, in the code, and that should get you 95% of of the way there. I hope this helps!

@elkizana
Copy link
Author

thanks @adamschwartz ! I did invert all the values but with no success. The tabs keep adding to the right.

@elkizana
Copy link
Author

elkizana commented Jun 1, 2021

did it with these changes :
in chrome-tabs.js :
line 183 : transform: translate3d(${ -position }px, 0, 0)
in css changed left : 0 to right: 0 in .chrome-tabs .chrome-tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants