Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect abbreviations for values rounded up #187

Closed
gscottolson opened this issue Jun 22, 2014 · 0 comments
Closed

Incorrect abbreviations for values rounded up #187

gscottolson opened this issue Jun 22, 2014 · 0 comments
Labels
Milestone

Comments

@gscottolson
Copy link

There is a specific case in Numeral where values with abbreviation formats are not rounded up properly to the next abbreviation. There are two test cases I added (locally) that fail to format properly:

...
[999950,'0.0a','1m'],
[999999999,'0.0a','1b'],
...

The above cases will output incorrect abbreviation values:

999950 ⟶ 1000.0k
999999999 ⟶ 1000.0m

The logic around abbreviation bracketing is causing this issue. I tried creating a patch for this, but I couldn’t find a quick solution that didn’t introduce additional test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants