WIP: Upgrade prettier to 2.3 and fix some of the issues #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking the time to begin working on this! This project being stuck on 2.3 was a dealbreaker for me as well. I'm also unfortunately fairly busy recently but this has been something I've been interested in for quite some time now so it's great to see some activity in this repository. |
|
looooking forward this gonna be worked out, right now I'm still using prettier 2.2 and plugin ruby 1.x , prettier 2.3 really have a better experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A huge step in the right direction to get prettier-html-templates and prettier-plugin-erb working with prettier 2.3 and newer.
Quite a few tests are passing but this isn't finished yet, and I'm afraid I won't have time soon to spend on this. So if anyone else wants to pick up the torch feel free to do so!
Related issues this PR could fix if it was complete: adamzapasnik/prettier-plugin-erb#49 #22