Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELVEWHEEL file makes reproducibility difficult #36

Closed
jvolkman opened this issue Apr 15, 2023 · 4 comments
Closed

DELVEWHEEL file makes reproducibility difficult #36

jvolkman opened this issue Apr 15, 2023 · 4 comments

Comments

@jvolkman
Copy link

The DELVEWHEEL file in dist-info contains the arguments passed to the program at repair time. Various build strategies will use temporary directories which then leak into this file, causing it to not be reproducible across runs.

It might be possible to setup a build environment and pass only relative paths for the input wheel, output directory, and lib paths. But with symlinking being tricky (impossible?) on Windows, that also becomes a difficult task.

It looks like only the Version entry in the file is used at a later time. The Arguments entry is stored but doesn't appear to be ever read again. Would you be open to omitting it, either outright or with some CLI option?

@adang1345
Copy link
Owner

The Arguments entry has been useful in diagnosing issues, so I'd like to keep it. But to support your use case, I added the --no-diagnostic flag.

@ofek
Copy link

ofek commented Feb 1, 2024

Can this please be reopened so SOURCE_DATE_EPOCH may be supported? It appears that other patchers support this:

@adang1345
Copy link
Owner

If you want support for SOURCE_DATE_EPOCH, then please open a separate issue.

@ofek
Copy link

ofek commented Feb 2, 2024

#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants