Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigateToHomeRoute() issue with Start Controller? #1037

Closed
brian-learningpool opened this issue Apr 28, 2016 · 3 comments
Closed

navigateToHomeRoute() issue with Start Controller? #1037

brian-learningpool opened this issue Apr 28, 2016 · 3 comments
Labels

Comments

@brian-learningpool
Copy link
Member

I was wondering should the router's navigateToHomeRoute() function consider whether the start controller is enabled, and specifically if it's being forced? Without this it appears possible to click on a home icon and get routed to an un-intended menu, rather than the landing page.

@moloko
Copy link
Contributor

moloko commented May 4, 2016

This is a good point... we would normally hide the home/back button on any start pages using CSS - but appreciate that is going to be tough to do if you're using the AT.

Or are you referring to what happens when you're in a standard content page and select the home/back button? In that instance I would generally want the user to be sent back to the main menu and not the 'start page' - mainly because we use the start controller functionality to include a page we want the user to be shown before the menu and then - generally - never seen again (oftentimes we'll include an option on the menu somewhere to allow you to get back to it, but you're rarely sent to it again).

Maybe the way to address this is instead to allow for more control over when the home/back button is shown and over what clicking this button does (with the default being to go back in the history, as it does now)?

@moloko
Copy link
Contributor

moloko commented Jul 22, 2016

Now being addressed in #1152 I think?

@brian-learningpool
Copy link
Member Author

Yes, this is resolved with the new _isMenuDisabled attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants