Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bad references #1517

Closed
oliverfoster opened this issue Apr 9, 2017 · 0 comments · Fixed by #1518
Closed

fix bad references #1517

oliverfoster opened this issue Apr 9, 2017 · 0 comments · Fixed by #1518

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Apr 9, 2017 •
edited
Loading

  1. fix bowser references
    https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/scriptLoader.js#L21-L22
    https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/device.js#L4

    the actual location is libraries/bowser

  2. fix old core files references
    plus remove all coreJS, coreModels. coreViews, coreCollections style references

  3. fixed helpers references

  4. fix drawer.js indentation
@oliverfoster oliverfoster changed the title fix bad reference to bowser fix bad references Apr 9, 2017
@oliverfoster oliverfoster mentioned this issue Apr 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue/1517: fixed bad references adaptlearning/adapt_framework
1 participant
@oliverfoster