Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minification issues #1966

Closed
oliverfoster opened this issue Feb 14, 2018 · 5 comments
Closed

Minification issues #1966

oliverfoster opened this issue Feb 14, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Feb 14, 2018

Subject of the issue

adapt/js/adapt.min.js should be minified by uglifyjs
adapt/js/build.min.js shouldn't be minified by uglifyjs as it is json

es6 is currently not supported by a released version of grunt-contrib-uglifyjs
this means the javascript command doesn't minify the adapt.min.js file properly due to a let statement in the notify module

also remove ie8 support from uglifier

@oliverfoster oliverfoster self-assigned this Feb 14, 2018
@brian-learningpool
Copy link
Member

brian-learningpool commented Feb 15, 2018

I think we should remove thelet statement to resolve this, and review and update the code for v4 (or a later version of v3) rather than introducing ES 6 piecemeal.

@oliverfoster
Copy link
Member Author

cool, i'll have a look through the core bits as i go, any plugin containing es6 will break after i reinstate minification. so could be a bit of a hassle

@oliverfoster
Copy link
Member Author

@moloko
Copy link
Contributor

moloko commented Feb 16, 2018

find it a bit depressing that we can't use the only two bits of ES6 that are actually supported in ALL current browsers but there you go, I guess there's little we can do.

@oliverfoster oliverfoster changed the title minification issues Minification issues Feb 16, 2018
@oliverfoster
Copy link
Member Author

v5 I'm going for webpack. So we're not far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants