adapt_framework: Reset on revisit isn't complete before page render

[oliverfoster]

Subject of the issue

The code to reset on revisit now lives in the preRender function of the PageView.

adapt_framework/src/core/js/views/pageView.js

Lines 8 to 11 in 657fea6

	this.model.getAllDescendantModels().forEach(model => {
	if (!model.checkIfResetOnRevisit) return;
	model.checkIfResetOnRevisit();
	});

It causes an asynchronous cascade of resets and completion check in AdaptModel from the components to the page.

adapt_framework/src/core/js/models/adaptModel.js

Lines 259 to 269 in 657fea6

	checkCompletionStatus() {
	// defer to allow other change:_isComplete handlers to fire before cascading to parent
	Adapt.checkingCompletion();
	_.defer(this.checkCompletionStatusFor.bind(this), '_isComplete');
	}
	checkInteractionCompletionStatus() {
	// defer to allow other change:_isInteractionComplete handlers to fire before cascading to parent
	Adapt.checkingCompletion();
	_.defer(this.checkCompletionStatusFor.bind(this), '_isInteractionComplete');
	}

Which when started by a component are never finished before the page has started nor finished rendering. There are 4 layers of deferred completion checks with components, blocks, articles and pages, but only one defer holding the postRender function of the page. Meaning the postRender calls in sequence with the component completion checks.

adapt_framework/src/core/js/views/adaptView.js

Lines 50 to 56 in eed48b3

	_.defer(() => {
	// don't call postRender after remove
	if (this._isRemoved) return;
	this.postRender();
	Adapt.trigger(`${type}View:postRender view:postRender`, this);
	});

An entire page and its content are rendered before the whole set of descendent models are properly reset on revisit.
This causes issues if the reset state of a block should be derived after the page prerender and before the block is rendered and whilst a component is set to reset on revisit - such is the case in the new version of trickle where trickle will stop only if the block is incomplete, which it should be but isn't yet.

Proposed solution

Have the router perform the reset on revisit and wait for the cascade to finish before rendering the page.

[oliverfoster]

Accidentally commit fix to master on eed48b3 reverted on c29e0f9