Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt_framework: umd module fixes broke nested require statements #3188

Closed
oliverfoster opened this issue Jul 6, 2021 · 0 comments · Fixed by #3189
Closed

adapt_framework: umd module fixes broke nested require statements #3188

oliverfoster opened this issue Jul 6, 2021 · 0 comments · Fixed by #3189
Assignees

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jul 6, 2021

Subject of the issue

define(function() { 
  const module = require('modulename');
});

Modules with the above import style (adapt-devtools) were broken with the last version of babel-plugin-transform-amd-to-es6 due to the fixes for umd (adapt-chart) to amd conversion.

Bump babel-plugin-transform-amd-to-es6 from v0.5.3 to v0.5.4 to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant