Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Refactor CacheManager to use cachepath grunt option internally (fixes #3599) #3600

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix: Refactor CacheManager to use cachepath grunt option internally (fixes #3599) #3600

merged 1 commit into from
Sep 27, 2024

Conversation

taylortom
Copy link
Member

@taylortom taylortom commented Sep 19, 2024 •
edited
Loading

Fixes #3599

Added this as a draft for now, as not sure if there was a specific reason for setting a custom cache path in the current way.

Fix

  • Updates CacheManager's tempPath getter to pick up grunt.option('cachepath') - currently this is set externally outside of the CacheManager (in tasks/javascript.js)

Testing

Scenario 1

Run a standard grunt build

Scenario 2

Run build with --cachepath grunt option.
i.e.

grunt server-build:dev --cachepath=XXX

@taylortom taylortom self-assigned this Sep 19, 2024
@taylortom taylortom marked this pull request as ready for review September 19, 2024 12:57
@taylortom taylortom changed the title Refactor CacheManager to use cachepath grunt option internally Fix: Refactor CacheManager to use cachepath grunt option internally Sep 19, 2024
@taylortom taylortom changed the title Fix: Refactor CacheManager to use cachepath grunt option internally Fix: Refactor CacheManager to use cachepath grunt option internally (fixes #3599) Sep 19, 2024
@taylortom taylortom added the bug label Sep 19, 2024
swashbuck
swashbuck approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit f1bcd40 into master Sep 27, 2024
2 checks passed
@oliverfoster oliverfoster deleted the issue/3599 branch September 27, 2024 21:26
github-actions bot pushed a commit that referenced this pull request Sep 27, 2024
@semantic-release-bot
Chore(release): 5.40.12 [skip ci]
0510fd4 
## [5.40.12](v5.40.11...v5.40.12) (2024-09-27)

### Fix

* Refactor CacheManager to use cachepath grunt option internally (#3600) ([f1bcd40](f1bcd40)), closes [#3600](#3600)

### Upgrade

* Bump serve-static from 1.15.0 to 1.16.2 (#3598) ([22a6d9c](22a6d9c)), closes [#3598](#3598)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.40.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@swashbuck swashbuck swashbuck approved these changes

@canstudios-nicolaw canstudios-nicolaw Awaiting requested review from canstudios-nicolaw

@ethan-lp ethan-lp Awaiting requested review from ethan-lp

@eleanor-heath eleanor-heath Awaiting requested review from eleanor-heath

@lemmyadams lemmyadams Awaiting requested review from lemmyadams

Assignees

@taylortom taylortom

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

last.touch path should use cachepath option
4 participants
@taylortom @swashbuck @oliverfoster @cahirodoherty-learningpool