Fix KeyError exception when there is no earnings or financials data on a ticker. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a ticker. Deliver an empty list to denote the missing iterable data.
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 96.24% 96.31% +0.07%
==========================================
Files 13 13
Lines 1596 1601 +5
==========================================
+ Hits 1536 1542 +6
+ Misses 60 59 -1
Continue to review full report at Codecov.
|
|
Thanks. Can you rebase please? |
|
@addisonlynch Done |
|
@reixd actually if you get the chance would you mind creating a new pull to master instead of dev? I hadn't looked at the dev branch and it needs to be deleted, has a bunch of messed up commits. Sorry about that. |
|
@reixd I took care of it actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliver an empty list to denote the missing iterable data.
git diff upstream/master -u -- "*.py" | flake8 --diff