Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on "require-readonly-react-props" #140

Closed
jaroslav-kubicek opened this issue Nov 20, 2019 · 2 comments
Closed

Turn on "require-readonly-react-props" #140

jaroslav-kubicek opened this issue Nov 20, 2019 · 2 comments

Comments

@jaroslav-kubicek
Copy link
Contributor

Let's fix todo and turn on https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-require-readonly-react-props
@mrtnzlml
Copy link
Member

Did you read the reason why is it turned off?

universe/src/eslint-config-adeira/ourRules.js

Line 270 in 6ce4801

'flowtype/require-readonly-react-props': OFF, // TODO: https://github.com/gajus/eslint-plugin-flowtype/pull/400#issuecomment-492828739

See: gajus/eslint-plugin-flowtype#400 (comment)

@jaroslav-kubicek
Copy link
Contributor Author

jaroslav-kubicek commented Nov 22, 2019 •
edited
Loading

oh damn, ok, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrtnzlml @jaroslav-kubicek