Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to ember-data v4.12.0 #747

Closed
wants to merge 6 commits into from

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented Mar 21, 2023

Fixes

Could not find module @ember/error imported from @ember-data/adapter/error

More info see: emberjs/data#8422

@derrabauke
Copy link
Contributor Author

Failing cause of embroider-build/embroider#1077

@derrabauke derrabauke changed the title chore(deps): upgrade to ember-data v4.11.3 chore(deps): upgrade to ember-data v4.7.2 Apr 18, 2023
@derrabauke
Copy link
Contributor Author

derrabauke commented Apr 18, 2023

Failing cause of embroider-build/embroider#1077

Upgrading ember-data only to v4.7.2 or adding a resolution for @embroider/macros prevents this.

We have issues with ember-data > v4.8.0 and @embroider/macros
(<v1.0.0) of the ember-cli-mirage dependency.
Adds a resolution for @embroider/macros caused by
transitive deps of ember-cli-mirage.
@derrabauke derrabauke changed the title chore(deps): upgrade to ember-data v4.7.2 chore(deps): upgrade to ember-data v4.12.0 Apr 18, 2023
@anehx
Copy link
Member

anehx commented Apr 20, 2023

Failing cause of embroider-build/embroider#1077

That issue is long resolved, we just need to use the alpha version of ember-cli-mirage as we do in other repos..

This hopefully resolves imcompatibilities for the ember-beta (v5) scenario
@derrabauke
Copy link
Contributor Author

derrabauke commented Apr 20, 2023

Fix on the way - But probably we have to upgrade to ember-simple-auth v5 first. Don't think they will back-port it.

@anehx
Copy link
Member

anehx commented May 4, 2023

Closed in favor of #763

@anehx anehx closed this May 4, 2023
@derrabauke derrabauke deleted the chore-dep-ember-data branch November 9, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants