refactor(expr): simplify filter(), also cache undue case

adhocore · Aug 16, 2018 · aab941e · aab941e
1 parent cd3cd33
commit aab941e
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/Expression.php b/src/Expression.php
@@ -150,16 +150,12 @@ public function filter(array $jobs, $time = null)
         foreach ($jobs as $name => $expr) {
             $expr = $this->normalizeExpr($expr);
 
-            if (isset($cache[$expr])) {
-                $dues[] = $name;
-
-                continue;
+            if (!isset($cache[$expr])) {
+                $cache[$expr] = $this->isCronDue($expr, $time);
             }
 
-            if ($this->isCronDue($expr, $time)) {
+            if ($cache[$expr]) {
                 $dues[] = $name;
-
-                $cache[$expr] = true;
             }
         }