Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search applications always show tag #1

Closed
NikoMuffin opened this issue Jun 6, 2021 · 23 comments
Closed

Search applications always show tag #1

NikoMuffin opened this issue Jun 6, 2021 · 23 comments
Labels
bug Something isn't working High Priority High Priority BUGS

Comments

@NikoMuffin
Copy link
Collaborator

NikoMuffin commented Jun 6, 2021

(Confirmed as bug by @Nomad-0 on Discord) Turning off search applications in settings does not prevent them from showing up as a tag when searched. For example, I don't use To Do. I turned off enable application in settings, turned off search "search tag only", but FS still triggers "Search to do" when I type in "todo+ and hit space. This is reproducible for all the search applications.

EDIT: I can confirm, but this happens to ALL of the search apps and plugins, not just translate!
This is a high priority bug
image

@NikoMuffin
Copy link
Collaborator Author

I'll close mine. I've linked mine to issue #38

@NikoMuffin NikoMuffin reopened this Jun 6, 2021
@NikoMuffin
Copy link
Collaborator Author

Reopening issue per Najah's/MrF's request as this ticket is more detailed

@NikoMuffin NikoMuffin added bug Something isn't working High Priority High Priority BUGS and removed duplicate This issue or pull request already exists labels Jun 6, 2021
@adirh3
Copy link
Owner

adirh3 commented Jun 7, 2021

This issue has been potentially fixed in version 0.9.85.20

@NikoMuffin
Copy link
Collaborator Author

This issue has been potentially fixed in version 0.9.85.20

Nomad asked me to check this. @adirh3 I cannot confirm fix unfortunately.

latest version:
image

Setting is turned off.
image

ToDo still firing:
image

Happening to all others too, including UI:
image

@Nomad-0
Copy link
Collaborator

Nomad-0 commented Jun 7, 2021

I'm having weird issues regarding this
Seeing to do tag whether it's enabled or disabled
-disabled
image
image

-enabled
image
image

but I'm not seeing or being able to use UI tag whether it's enabled or disabled
-enabled
image
image

@Nomad-0
Copy link
Collaborator

Nomad-0 commented Jun 7, 2021

update
suddenly I'm not seeing to do anymore, whether it's enabled or disabled
-enabled
image
image

-disabled
image
image

@adirh3
Copy link
Owner

adirh3 commented Jun 7, 2021

This issue has been potentially fixed in version 0.9.85.30

@Nomad-0
Copy link
Collaborator

Nomad-0 commented Jun 8, 2021

issue fixed on my end. @Metroid-Prime please check.

@NikoMuffin
Copy link
Collaborator Author

NikoMuffin commented Jun 9, 2021

@adirh3 @Nomad-0
Unfortunately I am still having this issue in v0.9.85.35
image

image

@Nomad-0
Copy link
Collaborator

Nomad-0 commented Jun 9, 2021

@adirh3 @Nomad-0
Unfortunately I am still having this issue in v0.9.85.25

do you mean version 0.9.85.35?

@NikoMuffin
Copy link
Collaborator Author

@adirh3 @Nomad-0
Unfortunately I am still having this issue in v0.9.85.25

do you mean version 0.9.85.35?

Yes, thank you @nomad. Corrected my original post.

@adirh3
Copy link
Owner

adirh3 commented Jun 9, 2021

@Nomad-0 That's a tag for a folder called todo, the issue with the search application is fixed.
@Metroid-Prime getting the tag back applies only after restart.

@NikoMuffin
Copy link
Collaborator Author

@adirh3 How about this one?
image

image

@adirh3
Copy link
Owner

adirh3 commented Jun 10, 2021

@adirh3 How about this one?
image

image

The "settings" search tag is being used to search for FS settings, it will not be removed.
You sure "Enabled application" was disabled when searching with that tag? if it did, then open an issue for that, since you shouldn't get Windows settings results if you disabled the app

@adirh3
Copy link
Owner

adirh3 commented Jun 12, 2021

@Metroid-Prime Can we close this?

@NikoMuffin
Copy link
Collaborator Author

NikoMuffin commented Jun 12, 2021

Still reproducible on my end.

I'm able to replicate it on every search.
Here's one of many other examples

Process plugin is turned off.
I type in "SnagIt"
FS finds process and triggers plugin (ugh)
image
image

@NikoMuffin
Copy link
Collaborator Author

The "settings" search tag is being used to search for FS settings, it will not be removed.

"settings" search tag is searching my SYSTEM settings, which again is turned off in my preferences! What am I doing wrong here?
image

The settings show everything is turned off so "settings" + space should not be triggering anything

@adirh3
Copy link
Owner

adirh3 commented Jun 12, 2021

This issue has been potentially fixed in version 0.9.85.45

@NikoMuffin
Copy link
Collaborator Author

The new version still has the problem, but only with the TAB button. Space no longer exhibits the issue

@adirh3
Copy link
Owner

adirh3 commented Jun 13, 2021

@Metroid-Prime You sure you're not confusing with FS settings?
@Nomad-0 Can you reproduce it?

@Nomad-0
Copy link
Collaborator

Nomad-0 commented Jun 14, 2021

@Nomad-0 Can you reproduce it?

No, I can't

@NikoMuffin
Copy link
Collaborator Author

NikoMuffin commented Jun 14, 2021

I believe this issue has now 'shifted' in the latest version if that makes any sense. I now have a better understanding of how it's behaving.

When the search tags are turned off, Fluent Search is searching for the "next tag that's on". For example, when I typed in "todo" and hit "tab", it triggers the command tab.
image

Then I went to the Command setting and turned enable application OFF, triggered FS and typed "todo" + tab again and now it triggers the App search tag which I have enabled.
image

When a search tag is turned off, for example todo, typing "todo" + hitting TAB should not trigger anything. This is confusing interface

@NikoMuffin
Copy link
Collaborator Author

Closing per Adir's req as re-design is coming hopefully to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority High Priority BUGS
Projects
None yet
Development

No branches or pull requests

3 participants