Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkoutlinesufo] duplicated start point check reports useless information #1315

Closed
punchcutter opened this issue Feb 26, 2021 · 0 comments · Fixed by #1318
Closed

[checkoutlinesufo] duplicated start point check reports useless information #1315

punchcutter opened this issue Feb 26, 2021 · 0 comments · Fixed by #1318
Assignees

Comments

@punchcutter
Copy link
Contributor

punchcutter commented Feb 26, 2021

In restore_contour_order the check for duplicate start points warns for tons of glyphs in my test font, but the information isn't useful. It warns of duplicate start points in glyphs that do not contain duplicate start points. For example in this simple glyph the first contour start point remains as the start point when overlaps are removed

uni30A7

uni30A7-overlapremoved

In this case (and many like it) there are no contour orders to restore. The result is a single contour. If the result is a single contour I would expect the first contour's start point to remain as the the start point like it does, but without any warnings.

Even in glyphs with more contours the warning isn't useful. Here the start points on contour 18, 15, 5, and 10 are all reported as duplicate start points. Before 02cb7fd the same glyphs do not have any "duplicate start point" warnings in restore_contour_order.

cid22144

cid22144-overlapremoved

Command checkoutlinesufo --all test-checkoutlinesufo.ufo -e
test-checkoutlinesufo.ufo.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants