Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotfexe] Improve merging of SinglePos chain targets #169

Open
brawer opened this issue Feb 17, 2017 · 0 comments
Open

[makeotfexe] Improve merging of SinglePos chain targets #169

brawer opened this issue Feb 17, 2017 · 0 comments

Comments

@brawer
Copy link
Contributor

brawer commented Feb 17, 2017

Currently, makeotf combines the chain targets for the following feature into the SinglePos lookups {A:-40, B:-40, C:-40} and {A:-111, B:-40}. The duplicated entry for B seems redundant. Instead of putting B into both SinglePos chain targets with the same value, makeotf could emit {A:-40, B:-40, C:-40} and {A:-111} to save some space.

feature test {
    pos X [A-B]' -40 B' -40 A' -40 Y;
    pos X A' -111 Y;
    pos X B' -40 A' -111 [A-C]' -40 Y;
} test;

This is definitely a contrived test case, and I’m not sure how wasteful the current encoding is in practice. Just noticed this while working on fonttools/fonttools#514.

@miguelsousa miguelsousa changed the title [makeotf] Improve merging of SinglePos chain targets [makeotfexe] Improve merging of SinglePos chain targets Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants