CheckOutlinesUFO pens work #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Jan 5, 2018
setup.py
Outdated
| @@ -154,6 +154,7 @@ def run(self): | |||
| 'mutatorMath>=2.1.0', #2.1.0 | |||
| 'ufolib>=2.1.1', | |||
| 'ufonormalizer>=0.3.2', | |||
| 'fontPens>=0.1.0.dev0' | |||
There was a problem hiding this comment.
only that fontPens is not on PyPI yet
https://pypi.python.org/pypi?%3Aaction=search&term=fontPens
so running setup.py install or pip install will fail
There was a problem hiding this comment.
May I help with getting fontPens on PyPI?
There was a problem hiding this comment.
thanks, I can do it.
tracking it here robotools/fontPens#7
There was a problem hiding this comment.
Awesome. Thanks! Also, after thinking about these changes further, I started to wonder about the change in behavior, which lead to this issue:
robotools/fontPens#8
If it's not expected behavior, I'd be happy to help by working on this issue.
…t fontPens.digestPointPen's getDigestPointsOnly() method matches the output of robofab.pens.digestPen's getDigestPointsOnly() method. (See robotools/fontPens#8 for more info.)
miguelsousa
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.