[ttfcomponentizer] Set maxp table's maxComponentElements value

[miguelsousa]

Even though FontTools recalculates most of maxp table values, maxComponentElements is not one of them and needs to be explicitly set otherwise it ends up as zero.

Related issues:
adobe-fonts/source-sans#154
adobe-fonts/source-serif#44

[anthrotype]

maybe fonttools should do that. if you like to work on a PR i'd be happy to review

[miguelsousa]

@anthrotype upon looking at the code it seems that all that's needed is a one-line change:

--- a/Lib/fontTools/ttLib/tables/_m_a_x_p.py
+++ b/Lib/fontTools/ttLib/tables/_m_a_x_p.py
@@ -107,6 +107,7 @@ class table__m_a_x_p(DefaultTable.DefaultTable):
                self.maxContours = maxContours
                self.maxCompositePoints = maxCompositePoints
                self.maxCompositeContours = maxCompositeContours
+               self.maxComponentElements = maxComponentElements
                self.maxComponentDepth = maxComponentDepth
                if allXMinIsLsb:
                        headTable.flags = headTable.flags | 0x2

I'll make the PR now.

[anthrotype]

ouch! since when has this been broken?

[anthrotype]

according to git blame, since day one (Dec 16 1999)
good catch!

[anthrotype]

https://github.com/fonttools/fonttools/releases/tag/3.35.1

[miguelsousa]

thanks

[miguelsousa]

fixed via fonttools/fonttools#1433