Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the pill per default, enable only on .page or locahost #20

Open
buuhuu opened this issue Mar 19, 2024 · 0 comments
Open

Disable the pill per default, enable only on .page or locahost #20

buuhuu opened this issue Mar 19, 2024 · 0 comments

Comments

@buuhuu
Copy link
Collaborator

buuhuu commented Mar 19, 2024

This request is an ask to reverse the logic to show or not show the pill.

Currently it is not shown if:

  • on .live
  • if configured on prodHost
  • if configured isProd returns true

We should reverse this to use a white list and show it only if

  • on .page or localhost (as recommended in the README.md)
  • if configured and isProd returns false
  • if configured and not on prodHost

That way no user setting is needed when running aem-experimentation with crosswalk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant