Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for proper tracking in a speculative pre-rendering context #102

Merged
merged 2 commits into from
Oct 7, 2024
Merged

feat: add support for proper tracking in a speculative pre-rendering context #102

merged 2 commits into from
Oct 7, 2024

Conversation

ramboz
Copy link
Collaborator

@ramboz ramboz commented Oct 5, 2024 •
edited
Loading

Properly wrapping sampleRUM initialization behind prerendering events.

Related Issue

Fix #101

How Has This Been Tested?

Tested against petplace.com

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ramboz ramboz requested a review from kptdobe October 5, 2024 01:22
@ramboz ramboz marked this pull request as ready for review October 5, 2024 01:22
@ramboz ramboz requested review from trieloff and rofe October 5, 2024 01:22
@kptdobe
Copy link
Contributor

kptdobe commented Oct 7, 2024

Makes sense. Thanks @ramboz.

@kptdobe kptdobe merged commit aba822a into main Oct 7, 2024
4 checks passed
@kptdobe kptdobe deleted the prerender-support branch October 7, 2024 08:25
adobe-bot pushed a commit that referenced this pull request Oct 7, 2024
@semantic-release-bot
chore(release): 2.6.0 [skip ci]
c58d021 
# [2.6.0](v2.5.7...v2.6.0) (2024-10-07)

### Features

* add support for proper tracking in a speculative pre-rendering context ([#102](#102)) ([aba822a](aba822a))
@adobe-bot
Copy link

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@trieloff
Copy link
Contributor

trieloff commented Oct 7, 2024

I think this is wrong. Pageviews that are only pre-rendered, but not actually seen should be excluded in reporting, not in collection.
In addition, if we wanted to implement this behavior, it should go into rum-js, and should not be the responsibility of the site to call sampleRUM conditionally.

kptdobe added a commit that referenced this pull request Oct 7, 2024
@kptdobe
Revert "feat: add support for proper tracking in a speculative pre-re…
543fa72 
…ndering context (#102)"

This reverts commit aba822a.
adobe-bot pushed a commit that referenced this pull request Oct 7, 2024
@semantic-release-bot
chore(release): 2.6.1 [skip ci]
496e1f2 
## [2.6.1](v2.6.0...v2.6.1) (2024-10-07)

### Reverts

* Revert "feat: add support for proper tracking in a speculative pre-rendering context ([#102](#102))" ([543fa72](543fa72))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kptdobe kptdobe kptdobe approved these changes

@trieloff trieloff Awaiting requested review from trieloff

@rofe rofe Awaiting requested review from rofe

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inflated page views when speculative pre-rendering is enabled
4 participants
@ramboz @kptdobe @adobe-bot @trieloff