Plugin menu #105
Merged
Plugin menu #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 99.21% 99.93% +0.71%
==========================================
Files 44 45 +1
Lines 1404 1504 +100
==========================================
+ Hits 1393 1503 +110
+ Misses 11 1 -10 ☔ View full report in Codecov by Sentry. |
* chore: linting * feat: delete plugin * fix: isEnabled condition * chore: typo * chore: jsdoc * feat: display message in destructive modal * chore: switch from plugin count to enumeration * feat: unpublish plugin * chore: do not rely on status in plugin condition
* feat: support development environment in switcher * fix: show preview last mod in dev
* feat: initial custom views implementation * feat: initial json render experience * feat: complete json view * fix: more tests * fix: remove console.log * fix: formatting * fix: test * fix: logo, remove custom views logic from switchEnv * feat: data stats, sorting * fix: total stat, unused elements * fix: localization of json view * fix: spectrum 2 updates * fix: remove tabs, update test * fix: RUM tracking * Update src/extension/app/components/search/search.js Co-authored-by: Raphael Wegmueller <github@rofe.com> * Update src/extension/app/spectrum-2.css.js Co-authored-by: Raphael Wegmueller <github@rofe.com> * fix: rename custom-views to views * fix: use RESTRICTED_PATHS from contstants.js * fix: special views support, don't wait for status * fix: hitting enter refreshes the page --------- Co-authored-by: Raphael Wegmueller <github@rofe.com>
* feat: initial custom views implementation * feat: initial json render experience * feat: complete json view * fix: more tests * fix: remove console.log * fix: formatting * fix: test * fix: logo, remove custom views logic from switchEnv * feat: data stats, sorting * fix: total stat, unused elements * fix: localization of json view * fix: spectrum 2 updates * fix: remove tabs, update test * fix: RUM tracking * Update src/extension/app/components/search/search.js Co-authored-by: Raphael Wegmueller <github@rofe.com> * Update src/extension/app/spectrum-2.css.js Co-authored-by: Raphael Wegmueller <github@rofe.com> * fix: rename custom-views to views * fix: use RESTRICTED_PATHS from contstants.js * fix: special views support, don't wait for status * fix: hitting enter refreshes the page --------- Co-authored-by: Raphael Wegmueller <github@rofe.com>
…nto plugin-menu
dylandepass
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
@rofe I asked killian about the underlay and he didn't want it.. The good news is that if you set the background-color of the underlay to transparent it still works. So I think we can do that and still have the same experience. Fine with that change being in a future PR.
He also confirmed the button should not be a toggle. So perfect that you removed that.
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.