Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Loading in action-bar #120

Merged
merged 29 commits into from
Apr 25, 2024
Merged

feat: Loading in action-bar #120

merged 29 commits into from
Apr 25, 2024

Conversation

dylandepass
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (d342faf) to head (9faee9b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   99.93%   97.88%   -2.06%     
==========================================
  Files          45       45              
  Lines        1531     1560      +29     
==========================================
- Hits         1530     1527       -3     
- Misses          1       33      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rofe
rofe requested changes Apr 25, 2024
View reviewed changes
src/extension/app/store/app.js Show resolved Hide resolved
src/extension/app/store/app.js Outdated Show resolved Hide resolved
src/extension/_locales/en/messages.json Outdated Show resolved Hide resolved
src/extension/_locales/en/messages.json Outdated Show resolved Hide resolved
src/extension/_locales/en/messages.json Outdated Show resolved Hide resolved
src/extension/app/plugins/publish/publish.js Outdated Show resolved Hide resolved
src/extension/app/plugins/reload/reload.js Outdated Show resolved Hide resolved
src/extension/app/store/app.js Show resolved Hide resolved
src/extension/app/store/app.js Show resolved Hide resolved
src/extension/app/components/plugin/plugin-action-bar.js Show resolved Hide resolved
dylandepass and others added 10 commits April 25, 2024 09:25
@dylandepass @rofe
Update src/extension/app/store/app.js
50386e7 
Co-authored-by: Raphael Wegmueller <github@rofe.com>
@dylandepass @rofe
Update src/extension/_locales/en/messages.json
a5574ce 
Co-authored-by: Raphael Wegmueller <github@rofe.com>
@dylandepass @rofe
Update src/extension/_locales/en/messages.json
1ee737b 
Co-authored-by: Raphael Wegmueller <github@rofe.com>
@dylandepass @rofe
Update src/extension/_locales/en/messages.json
9dd04d9 
Co-authored-by: Raphael Wegmueller <github@rofe.com>
@dylandepass @rofe
Update src/extension/app/components/action-bar/activity-action/activi…
57c22be 
…ty-action.css.js

Co-authored-by: Raphael Wegmueller <github@rofe.com>
@dylandepass @rofe
Update src/extension/app/components/action-bar/activity-action/activi…
2d399f8 
…ty-action.js

Co-authored-by: Raphael Wegmueller <github@rofe.com>
@dylandepass
fix: address some comments
9837604
@dylandepass
fix: rename SIDEKICK_STATE to STATE
730fc51
@dylandepass
fix: address more comments
3aae80a
@dylandepass
fix: switch to currentColor for checkmark icon
9faee9b
@dylandepass dylandepass merged commit a546a5d into main Apr 25, 2024
5 of 6 checks passed
@dylandepass dylandepass deleted the loading-in-actionbar branch April 25, 2024 17:41
trieloff pushed a commit that referenced this pull request Apr 25, 2024
@semantic-release-bot
chore(release): 1.20.0 [skip ci]
4fbfc7a 
# [1.20.0](v1.19.0...v1.20.0) (2024-04-25)

### Bug Fixes

* remove singleton and add new test framework ([#119](#119)) ([1e32e23](1e32e23))

### Features

* **context-menu:** remove open preview option ([#118](#118)) ([3464ec1](3464ec1)), closes [#115](#115) [#114](#114) [#114](#114) [#85](#85) [#85](#85) [#116](#116) [#116](#116)
* Loading in action-bar ([#120](#120)) ([a546a5d](a546a5d))
@trieloff
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rofe pushed a commit that referenced this pull request Apr 27, 2024
@dylandepass @rofe
feat: Loading in action-bar (#120)
b6bb9c9
rofe pushed a commit that referenced this pull request Apr 27, 2024
@semantic-release-bot @rofe
chore(release): 1.20.0 [skip ci]
ae85b81 
# [1.20.0](v1.19.0...v1.20.0) (2024-04-25)

### Bug Fixes

* remove singleton and add new test framework ([#119](#119)) ([1e32e23](1e32e23))

### Features

* **context-menu:** remove open preview option ([#118](#118)) ([3464ec1](3464ec1)), closes [#115](#115) [#114](#114) [#114](#114) [#85](#85) [#85](#85) [#116](#116) [#116](#116)
* Loading in action-bar ([#120](#120)) ([a546a5d](a546a5d))
rofe added a commit that referenced this pull request Apr 29, 2024
@rofe
Squashed commit of the following:
fac1cb0 
commit a66cd65
Author: rofe <github@rofe.com>
Date:   Sun Apr 28 11:42:48 2024 +0200

    chore: revert

commit feccb29
Author: rofe <github@rofe.com>
Date:   Sun Apr 28 11:41:14 2024 +0200

    chore: adjust test

commit ac230cb
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Sat Apr 27 20:44:12 2024 +0000

    chore(release): 1.20.3 [skip ci]

    * toast when activating config, improve tests ([#126](#126)) ([4551c33](4551c33))

commit 4551c33
Author: dylandepass <dylandepass@gmail.com>
Date:   Sat Apr 27 16:41:52 2024 -0400

    fix: toast when activating config, improve tests (#126)

commit 3e731b4
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Sat Apr 27 18:33:38 2024 +0000

    chore(release): 1.20.2 [skip ci]

    * don't load content script when hidden ([#125](#125)) ([68bbf3d](68bbf3d))

commit 68bbf3d
Author: dylandepass <dylandepass@gmail.com>
Date:   Sat Apr 27 14:31:34 2024 -0400

    fix: don't load content script when hidden (#125)

    * fix: don't load content script when hidden

    * fix: test and unreachable code

commit 0b6e0ee
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Fri Apr 26 12:10:03 2024 +0000

    chore(release): 1.20.1 [skip ci]

    * palette styling ([#124](#124)) ([3084c4d](3084c4d))

commit 3084c4d
Author: dylandepass <dylandepass@gmail.com>
Date:   Fri Apr 26 08:07:44 2024 -0400

    fix: palette styling (#124)

commit 4fbfc7a
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Thu Apr 25 17:43:53 2024 +0000

    chore(release): 1.20.0 [skip ci]

    * remove singleton and add new test framework ([#119](#119)) ([1e32e23](1e32e23))

    * **context-menu:** remove open preview option ([#118](#118)) ([3464ec1](3464ec1)), closes [#115](#115) [#114](#114) [#114](#114) [#85](#85) [#85](#85) [#116](#116) [#116](#116)
    * Loading in action-bar ([#120](#120)) ([a546a5d](a546a5d))

commit a546a5d
Author: dylandepass <dylandepass@gmail.com>
Date:   Thu Apr 25 13:41:50 2024 -0400

    feat: Loading in action-bar (#120)

commit 1e32e23
Author: dylandepass <dylandepass@gmail.com>
Date:   Wed Apr 24 20:33:58 2024 -0400

    fix: remove singleton and add new test framework (#119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofe rofe rofe approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylandepass @trieloff @rofe