Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toast when activating config, improve tests #126

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

dylandepass
Copy link
Member

Toast was broken when activating /.helix/config
Improved tests around updatePreview

@dylandepass dylandepass requested a review from rofe April 27, 2024 18:30
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (3084c4d) to head (a91ffe7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files          45       45              
  Lines        1560     1559       -1     
==========================================
- Hits         1527     1526       -1     
  Misses         33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylandepass dylandepass merged commit 4551c33 into main Apr 27, 2024
6 checks passed
@dylandepass dylandepass deleted the activate-config branch April 27, 2024 20:41
trieloff pushed a commit that referenced this pull request Apr 27, 2024
## [1.20.3](v1.20.2...v1.20.3) (2024-04-27)

### Bug Fixes

* toast when activating config, improve tests ([#126](#126)) ([4551c33](4551c33))
@trieloff
Copy link

🎉 This PR is included in version 1.20.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rofe added a commit that referenced this pull request Apr 29, 2024
commit a66cd65
Author: rofe <github@rofe.com>
Date:   Sun Apr 28 11:42:48 2024 +0200

    chore: revert

commit feccb29
Author: rofe <github@rofe.com>
Date:   Sun Apr 28 11:41:14 2024 +0200

    chore: adjust test

commit ac230cb
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Sat Apr 27 20:44:12 2024 +0000

    chore(release): 1.20.3 [skip ci]

    * toast when activating config, improve tests ([#126](#126)) ([4551c33](4551c33))

commit 4551c33
Author: dylandepass <dylandepass@gmail.com>
Date:   Sat Apr 27 16:41:52 2024 -0400

    fix: toast when activating config, improve tests (#126)

commit 3e731b4
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Sat Apr 27 18:33:38 2024 +0000

    chore(release): 1.20.2 [skip ci]

    * don't load content script when hidden ([#125](#125)) ([68bbf3d](68bbf3d))

commit 68bbf3d
Author: dylandepass <dylandepass@gmail.com>
Date:   Sat Apr 27 14:31:34 2024 -0400

    fix: don't load content script when hidden (#125)

    * fix: don't load content script when hidden

    * fix: test and unreachable code

commit 0b6e0ee
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Fri Apr 26 12:10:03 2024 +0000

    chore(release): 1.20.1 [skip ci]

    * palette styling ([#124](#124)) ([3084c4d](3084c4d))

commit 3084c4d
Author: dylandepass <dylandepass@gmail.com>
Date:   Fri Apr 26 08:07:44 2024 -0400

    fix: palette styling (#124)

commit 4fbfc7a
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Thu Apr 25 17:43:53 2024 +0000

    chore(release): 1.20.0 [skip ci]

    * remove singleton and add new test framework ([#119](#119)) ([1e32e23](1e32e23))

    * **context-menu:** remove open preview option ([#118](#118)) ([3464ec1](3464ec1)), closes [#115](#115) [#114](#114) [#114](#114) [#85](#85) [#85](#85) [#116](#116) [#116](#116)
    * Loading in action-bar ([#120](#120)) ([a546a5d](a546a5d))

commit a546a5d
Author: dylandepass <dylandepass@gmail.com>
Date:   Thu Apr 25 13:41:50 2024 -0400

    feat: Loading in action-bar (#120)

commit 1e32e23
Author: dylandepass <dylandepass@gmail.com>
Date:   Wed Apr 24 20:33:58 2024 -0400

    fix: remove singleton and add new test framework (#119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants